Add 0.8 one-shot configuration adapter - #910
Merged
Gudge (MGudgin) merged 1 commit intoAug 19, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase5b
branch
from
August 14, 2026 21:38
368cd73 to
90915db
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the mutable 0.8.0-alpha one-shot contract adapter to the current wire model.
Changes:
- Maps stable, experimental, compatibility-alias, and development containment fields.
- Adds expected-value and current-wire equivalence tests.
- Registers the development adapter module for later dispatch integration.
Show a summary per file
| File | Description |
|---|---|
config_contract_adapters/mod.rs |
Registers the development adapter. |
dev/mod.rs |
Exposes the one-shot adapter module. |
dev/one_shot.rs |
Implements contract-to-wire conversion. |
one_shot_tests/mod.rs |
Organizes adapter tests. |
one_shot_tests/common.rs |
Provides shared test helpers. |
one_shot_tests/stable_candidate.rs |
Tests stable fields and aliases. |
one_shot_tests/experimental.rs |
Tests experimental fields and containments. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Balanced
Branden Bonaby (bbonaby)
previously approved these changes
Aug 17, 2026
Base automatically changed from
user/gudge/version_specific_config_parsers_phase5a
to
main
August 19, 2026 15:29
This PR adds the mutable 0.8.0-alpha one-shot configuration adapter. Details * Map the complete stable-candidate and closed experimental one-shot contracts into the current wire model. * Preserve compatibility aliases, development containment values, denial capture, Windows Sandbox, WSLC, telemetry, and one-shot exclusions. * Add expected-wire and current-wire equivalence tests organized by the future publication boundary. Tests * `cargo fmt --all -- --check` * `cargo check -p wxc_common --all-targets` * `cargo clippy -p wxc_common --all-targets -- -D warnings` * `cargo test -p mxc_config_contract` (324 tests passed) * `cargo test -p wxc_common` (696 tests passed, 1 ignored) * `$env:RUSTDOCFLAGS='-D missing-docs'; cargo doc -p mxc_config_contract --no-deps` * `git diff --check origin/main..HEAD` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase5b
branch
from
August 19, 2026 15:29
90915db to
f9b1a57
Compare
Branden Bonaby (bbonaby)
approved these changes
Aug 19, 2026
Gudge (MGudgin)
deleted the
user/gudge/version_specific_config_parsers_phase5b
branch
August 19, 2026 22:57
Gudge (MGudgin)
pushed a commit
that referenced
this pull request
Aug 20, 2026
This PR updates the version-specific parser plan to match the current state of the work: Phase 5 is merged end to end, and the capabilities parity finding is being remediated in the Phase 5 stack rather than on the Phase 6 branch. Details * Mark Phases 5B, 5C, and 5D merged in PRs #910, #929, and #941, and record #949 as retargeted onto main now that the stack beneath it has landed. * Add PR #966 to the Phase 5 status list as the capabilities remediation, and repoint the two "top of the Phase 5 stack" references at it. * Resolve remediation item 2 of the Phase 6 review finding: the ProcessContainerCapability newtype landed, the parse-time versus conversion-time asymmetry is now the accepted state, and the shared-constant and parity-test drift risk is recorded as still open. * Note that the unpushed Phase 6 branch carries a duplicate capabilities commit that must be dropped when it rebases onto the merged stack. Tests * Documentation-only change; no build, lint, or test gate applies. * git diff --check passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a8e0d88-21dd-48e5-8e44-df2393b8a664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the mutable
0.8.0-alphaone-shot configuration adapter.Details
Tests
cargo fmt --all -- --checkcargo check -p wxc_common --all-targetscargo clippy -p wxc_common --all-targets -- -D warningscargo test -p mxc_config_contract(324 tests passed)cargo test -p wxc_common(696 tests passed, 1 ignored)$env:RUSTDOCFLAGS='-D missing-docs'; cargo doc -p mxc_config_contract --no-depsgit diff --check origin/main..HEADMicrosoft Reviewers: Open in CodeFlow